- 
                Notifications
    
You must be signed in to change notification settings  - Fork 10.5k
 
Revert trimming test workarounds #58272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 
           We need to get the updated sdk first though?  | 
    
          
 Yep, I'll change the base of this PR to the SDK update PR when it gets opened.  | 
    
              
                    wtgodbe
  
              
              approved these changes
              
                  
                    Oct 16, 2024 
                  
              
              
            
            
    
  captainsafia 
      pushed a commit
      that referenced
      this pull request
    
      Dec 31, 2024 
    
    
  
    
  captainsafia 
      pushed a commit
      that referenced
      this pull request
    
      Feb 11, 2025 
    
    
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    area-infrastructure
  Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Now that dotnet/sdk#43070 is merged, we should be able to revert the linker workarounds applied in #57742.
Fixes #57846